6.0 KiB
Contributing
Floci is MIT licensed and welcomes contributions of all kinds.
Join us on Slack: the fastest way to reach maintainers for questions, design tradeoffs, or feedback on an approach before you build it.
Ways to Help
- Bug reports: open a GitHub issue with a minimal reproduction
- Missing API actions: open a feature request
- Pull requests: new service actions, bug fixes, documentation improvements
Development Setup
# Clone
git clone https://github.com/floci-io/floci.git
cd floci
# Run in dev mode (hot reload, port 4566)
mvn quarkus:dev
# Run all tests
mvn test
# Run a specific test
mvn test -Dtest=SsmIntegrationTest
mvn test -Dtest=SsmIntegrationTest#putParameter
Commit Message Format
This project uses Conventional Commits, required for semantic-release to generate the changelog and version bumps automatically.
The PR title is validated automatically by CI and must follow this format, since it becomes the squash-merge commit message that semantic-release reads.
Format
<type>[optional scope]: <description>
| Type | Effect |
|---|---|
feat |
New feature → minor version bump |
fix |
Bug fix → patch version bump |
perf |
Performance improvement → patch |
revert |
Reverts a previous commit → patch |
docs |
Documentation only → no version bump |
style |
Formatting, whitespace → no version bump |
chore |
Build/CI/housekeeping → no version bump |
refactor |
Code restructure → no version bump |
test |
Adding/updating tests → no version bump |
build |
Build system changes → no version bump |
ci |
CI workflow changes → no version bump |
feat!: or BREAKING CHANGE: |
Breaking change → major bump |
Valid examples ✅
feat(dynamodb): add PartiQL ExecuteStatement support
fix(s3): make us-east-1 bucket creation idempotent
chore: release 1.5.16
feat!: remove legacy v1 endpoint
ci: add conventional commits lint workflow
Invalid examples ❌
Add PartiQL support # missing type
Feature: add something # not a valid type
feat : space before colon # space before colon
FIX(s3): uppercase type # type must be lowercase
feat(my scope): spaces in scope # scope cannot contain spaces
wip: still working on this # not a recognised type
Adding a New AWS Service
See AGENTS.md for the full architecture guide. AGENTS.md is the canonical agent instructions file for this repository, following the AGENTS.md standard. If your coding agent expects a different filename, create a local symlink to AGENTS.md instead of copying it.
ln -s AGENTS.md CLAUDE.md
ln -s AGENTS.md GEMINI.md
ln -s AGENTS.md COPILOT.md
Quick summary:
- Create
src/main/java/.../services/<service>/with a Controller, Service, andmodel/package - Pick the right protocol (see the protocol table in
AGENTS.md) - Register a
ServiceDescriptorinResolvedServiceCatalog(ServiceRegistryonly reads the catalog) - Add config in
EmulatorConfig.javaand in both the main and testapplication.yml - Add
*ServiceTest.javaand*IntegrationTest.javatests - Add the docs page, its
mkdocs.ymlnav entry, a Service Matrix row and a README row (make docs-checkgates the matrix)
Code Style
AGENTS.md carries the full list. The ones worth knowing before your first PR:
- Write explicit types. Do not use
var. Floci reproduces AWS wire contracts, so the concrete type at a call site is usually what a reviewer needs to see. The one exception is a record deconstruction pattern. - Import the classes you use. No fully-qualified names inline.
new ArrayList<>(), nevernew java.util.ArrayList<>(). Qualify only for a real name collision in that file, and say in a comment what collides. - No wildcard imports in
src/main. Static wildcards are fine in tests. - Never leave a
catchblock empty. If swallowing is correct, name the variableignoredorexpectedand say why in a comment. - Always use braces in conditionals, and use constructor injection.
- Tests: JUnit 5 with Hamcrest and RestAssured. Name methods as a camelCase
sentence or
method_scenario_expectation, nevertestX.
Existing code does not yet satisfy all of these everywhere. Match them in code you add or change, and leave unrelated cleanups for their own PR.
Pull Request Checklist
mvn testpasses- New or updated integration test added
- Commit messages follow Conventional Commits
- Code follows the style rules above
Please keep at most 5 open PRs at a time. A bot leaves an advisory note (label over-pr-limit) on PRs opened beyond that. See CONTRIBUTING.md for details.
Releases
Stable releases ship on the 1st and 3rd Tuesday of each month. Merging to main does not cut a release: the change rides the next train, and reaches the nightly image on the next nightly build.
Maintainers cut releases from main with the Release Cut workflow, which runs semantic-release over the Conventional Commits since the last tag. That is why the commit type matters: feat: and fix: move the version, docs: and chore: do not. CHANGELOG.md is generated from those messages and is not edited by hand; a genuine correction goes in a PR carrying the changelog-edit label.
Reporting Security Issues
Do not open public issues for security vulnerabilities. Use GitHub private vulnerability reporting instead.