first-commit

apps/daemon/tests/skill-id-aliases.test.ts

@@ -0,0 +1,119 @@
+// @ts-nocheck
+import { afterAll, beforeAll, describe, expect, it } from 'vitest';
+import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
+import { tmpdir } from 'node:os';
+import path from 'node:path';
+
+import {
+  SKILL_ID_ALIASES,
+  findSkillById,
+  listSkills,
+  resolveSkillId,
+} from '../src/skills.js';
+
+// Regression coverage for the editorial-collage → open-design-landing rename.
+// The daemon persists the chosen skill_id verbatim on a project row and
+// resolves it later by id, so a folder/frontmatter rename without a
+// compatibility shim would silently drop the skill prompt for projects
+// saved against the old id. These tests pin the alias map and the lookup
+// helper that every server-side resolver must go through.
+
+let skillsRoot;
+
+beforeAll(async () => {
+  skillsRoot = await mkdtemp(path.join(tmpdir(), 'od-skills-aliases-'));
+  // Mimic the on-disk shape the production registry expects: one
+  // directory per skill, each with a SKILL.md whose frontmatter `name`
+  // becomes the canonical id returned by listSkills().
+  await mkdir(path.join(skillsRoot, 'open-design-landing'), { recursive: true });
+  await writeFile(
+    path.join(skillsRoot, 'open-design-landing', 'SKILL.md'),
+    '---\nname: open-design-landing\ndescription: Atelier Zero landing.\n---\n\nbody\n',
+    'utf8',
+  );
+  await mkdir(path.join(skillsRoot, 'open-design-landing-deck'), {
+    recursive: true,
+  });
+  await writeFile(
+    path.join(skillsRoot, 'open-design-landing-deck', 'SKILL.md'),
+    '---\nname: open-design-landing-deck\ndescription: Atelier Zero deck.\n---\n\nbody\n',
+    'utf8',
+  );
+  // An untouched skill so we can prove the helper still resolves
+  // non-aliased ids and does not match by accident.
+  await mkdir(path.join(skillsRoot, 'simple-deck'), { recursive: true });
+  await writeFile(
+    path.join(skillsRoot, 'simple-deck', 'SKILL.md'),
+    '---\nname: simple-deck\ndescription: Plain deck.\n---\n\nbody\n',
+    'utf8',
+  );
+});
+
+afterAll(async () => {
+  if (skillsRoot) await rm(skillsRoot, { recursive: true, force: true });
+});
+
+describe('SKILL_ID_ALIASES', () => {
+  it('maps the editorial-collage rename to its current canonical id', () => {
+    expect(SKILL_ID_ALIASES['editorial-collage']).toBe('open-design-landing');
+    expect(SKILL_ID_ALIASES['editorial-collage-deck']).toBe(
+      'open-design-landing-deck',
+    );
+  });
+
+  it('is frozen so callers cannot mutate the deprecation list at runtime', () => {
+    expect(Object.isFrozen(SKILL_ID_ALIASES)).toBe(true);
+  });
+});
+
+describe('resolveSkillId', () => {
+  it('forwards deprecated ids to their canonical replacement', () => {
+    expect(resolveSkillId('editorial-collage')).toBe('open-design-landing');
+    expect(resolveSkillId('editorial-collage-deck')).toBe(
+      'open-design-landing-deck',
+    );
+  });
+
+  it('passes non-aliased ids through unchanged', () => {
+    expect(resolveSkillId('simple-deck')).toBe('simple-deck');
+    expect(resolveSkillId('totally-unknown')).toBe('totally-unknown');
+  });
+
+  it('returns the input unchanged for empty / non-string ids', () => {
+    expect(resolveSkillId('')).toBe('');
+    expect(resolveSkillId(undefined)).toBeUndefined();
+    expect(resolveSkillId(null)).toBeNull();
+  });
+});
+
+describe('findSkillById', () => {
+  it('resolves a project saved with the old editorial-collage id to the renamed skill', async () => {
+    const skills = await listSkills(skillsRoot);
+    const skill = findSkillById(skills, 'editorial-collage');
+    expect(skill).toBeDefined();
+    expect(skill.id).toBe('open-design-landing');
+    expect(skill.body).toContain('body');
+  });
+
+  it('resolves a project saved with the old editorial-collage-deck id to the renamed deck skill', async () => {
+    const skills = await listSkills(skillsRoot);
+    const skill = findSkillById(skills, 'editorial-collage-deck');
+    expect(skill).toBeDefined();
+    expect(skill.id).toBe('open-design-landing-deck');
+  });
+
+  it('still resolves current ids exactly', async () => {
+    const skills = await listSkills(skillsRoot);
+    expect(findSkillById(skills, 'open-design-landing')?.id).toBe(
+      'open-design-landing',
+    );
+    expect(findSkillById(skills, 'simple-deck')?.id).toBe('simple-deck');
+  });
+
+  it('returns undefined for unknown ids and missing inputs', async () => {
+    const skills = await listSkills(skillsRoot);
+    expect(findSkillById(skills, 'definitely-not-a-skill')).toBeUndefined();
+    expect(findSkillById(skills, '')).toBeUndefined();
+    expect(findSkillById(null, 'open-design-landing')).toBeUndefined();
+  });
+});